Remove Arguments.createArgumentsFromJSON and tests#1313
Merged
sonalgoyal merged 1 commit intoApr 28, 2026
Merged
Conversation
Remove the static createArgumentsFromJSON method from the Arguments class and clean up related references. The method implementation was deleted from python/zingg/client.py, docs references were removed from docs/pythonOss/markdown/_autosummary/zingg.client.Arguments.md and python/docs/_autosummary/zingg.client.Arguments.rst, and the corresponding unit test (test_createArgumentsFromJSON) was removed from test/testFebrl/testArgs.py.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Python Arguments.createArgumentsFromJSON entry point and cleans up associated references, aligning the Python client surface area with currently used/maintained APIs (Issue #1312).
Changes:
- Removed
Arguments.createArgumentsFromJSONfrompython/zingg/client.py. - Removed the corresponding unit test from
test/testFebrl/testArgs.py. - Updated generated API docs to drop the removed method (and other stale method references) from the
Argumentsdocumentation pages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
python/zingg/client.py |
Removes the createArgumentsFromJSON static method from Arguments. |
test/testFebrl/testArgs.py |
Deletes the unit test that exercised createArgumentsFromJSON. |
python/docs/_autosummary/zingg.client.Arguments.rst |
Updates autosummary method list to no longer include the removed/stale methods. |
docs/pythonOss/markdown/_autosummary/zingg.client.Arguments.md |
Removes markdown doc entries/sections for the removed method (and stale doc entries). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the static createArgumentsFromJSON method from the Arguments class and clean up related references. The method implementation was deleted from python/zingg/client.py, docs references were removed from docs/pythonOss/markdown/_autosummary/zingg.client.Arguments.md and python/docs/_autosummary/zingg.client.Arguments.rst, and the corresponding unit test (test_createArgumentsFromJSON) was removed from test/testFebrl/testArgs.py. fixes #1312